[Bug 463922] Review Request: ifstat - Interface statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463922





--- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2008-09-30 01:08:40 EDT ---
I have no intention to review this request, however:

(In reply to comment #5)
> about the debuginfo the package produces a empty debuginfo file, I have
> disabled 

As wolfy said in the comment 4, this is not allowed. Instead you _must_
create a useful debuginfo rpm correctly.
The culprit which prevents from creating correct debuginfo rpm is in
Makefile.in:
----------------------------------------------------------
    67  install-$(TARGET): $(TARGET)
    68          $(INSTALL) -d -m 755 $(DESTDIR)$(bindir)
    69          $(INSTALL) -p -s -m 755 $(TARGET) $(DESTDIR)$(bindir)/$(TARGET)
<--------------
    70          $(INSTALL) -d -m 755 $(DESTDIR)$(mandir)/man1
    71          $(INSTALL) -p -m 644 ifstat.1 $(DESTDIR)$(mandir)/man1/ifstat.1
----------------------------------------------------------
On the line 69, "install" command uses "-s" option, which strips installed
binary, which needs fixing.

By the way build log shows:
----------------------------------------------------------
+ /usr/bin/make -j2
gcc -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -O3 -fomit-frame-pointer -g0 -DHAVE_CONFIG_H 
-DNETSNMP_ENABLE_IPV6 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -Ulinux -Dlinux=linux -I/usr/include/rpm
-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe
-I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-I/usr/include/gdbm -I/usr/lib/perl5/5.10.0/i386-linux-thread-multi/CORE
-I/usr/include/net-snmp -c ifstat.c -o ifstat.o
----------------------------------------------------------
Compilar flags "-O3" "-fomit-frame-pointer" makes debugging almost impossible
so these flags
should be removed (note. the flag "-O3" is replaced by the latter "-O2",
however it is better
that -O3 is removed anyway)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]