Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462251 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giallu@xxxxxxxxx --- Comment #2 from Gianluca Sforna <giallu@xxxxxxxxx> 2008-09-29 03:45:52 EDT --- Additional stuff you should consider: * the %version and %release defines are redundant, since they are filled during build with the "Version" and "Release" tags content. * Source tag should include the full URI to the package; AFAICT this is not available unless you are paying support to Delano Scientific. If I am correct you will need to create the tarball from upstream SVN, documenting the procedure in the spec file (usually the easiest way is to add a small script to compose the tarball). More details about this at: https://fedoraproject.org/wiki/Packaging/SourceURL * There is no need to prepare and fill the docs directory, a single line in the files section like: %doc LICENSE DEVELOPERS README will do everything for you * it's the first time I see the sanity check on RPM_BUILD_ROOT before removing it. I can't remember any guideline against it, but I'd avoid it anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review