Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461131 --- Comment #28 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx> 2008-09-28 11:00:08 EDT --- (In reply to comment #24) > The length of name: > https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages > You need remove rev. It's date + 16 characters maximally. Why remove? "svn2261rev" has only 10 characters from 16 allowed?? > Source: > In this case source must be commented, how you get it. Something like "svn > export ... -r %{rev} ...; tar ..." Ok, I'm add this. (In reply to comment #25) > And also I see sim-debuginfo.i386: E: empty-debuginfo-package. > > Maybe you're stripping the debug. > https://fedoraproject.org/wiki/Packaging/Debuginfo Yes it is. "make install-strip" replaced by "make install" (In reply to comment #26) > I see absolutely no use for including an empty Authors file and eating an inode > for it. If/when the authors decide to add real content to that file, you'll > need to modify the spec anyway. Does it take more that 15 seconds to add the > file in the %doc line ? > > my .2c Hmmm... IMHO, one inode have no sense in performance or anywhere. Indeed 15 seconds already was be spend to add it, and delete also take more 15 secs... But main my argument is - this is file from upstream source package and it is file, what is recommended to put into %doc. (In reply to comment #27) > Well, I wouldn't pack empty files and probably remove them in cleaning phase, > but that's depend on maintainer. He can have approved package after fix of > release. Thanks for the choice. I'm going to keep the file here. http://koji.fedoraproject.org/koji/taskinfo?taskID=847700 http://hubbitus.net.ru/rpm/Fedora9/sim/sim-0.9.5-0.6.20080923svn2261rev.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review