Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463996 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #12 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-28 09:19:51 EDT --- Some notes: * SourceURL - You may want to use %{name} %{version} macros (especially %{version}) tag in sourceURL: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D * License - I cannot find out any parts in the source code which specifies the license to LGPL "version 2" specific (other than Makefile), so I think the license tag must be "LGPLv2+". Note that just putting "LGPLv2" copying file into the tarball does not specify the LGPL version to 2 only (due to the section 13 of LGPLv2 text). * Requires ---------------------------------------------------- %if "0%{fedora}" > "0.fc8" Requires: java-1.7.0-icedtea %else Requires: java-1.6.0-openjdk %endif ---------------------------------------------------- - Note that on F-9/10 icedtea does not exist (so I guess what you meant here is opposite to what is written here). Also "%{fedora}" tag is "10", "9", "8", not ".fc10" or so (this is %{?dist} tag). Finally this string comparison won't work for F-10: see: https://www.redhat.com/archives/fedora-devel-list/2008-May/msg02095.html Here if you want to have "java-1.7.0-icedtea" or "java-1.6.0-openjdk" added for Requires (and java-1.5.0-gcj is not sufficient), just ---------------------------------------------------- Requires: java >= 1.7 ---------------------------------------------------- is sufficient, because java-1.7.0-icedtea provides "java = 1.7.0" and java-1.6.0-openjdk provides "java = 1:1.6.0" (this has Epoch 1, so is higher than 1.7). Also "Requies: jpackage-utils" is needed: see: https://fedoraproject.org/wiki/Packaging/Java#Java_Packaging * Macros - Use macros for standard directories. For example /usr must be %{_prefix} (e.g. ---------------------------------------------------- export CLASSPATH=$CLASSPATH:`rpm -ql libswt3-gtk2|grep swt.jar|awk 'NR==1'` \n\ !!!! cd /usr\n\ %{_libdir}/tuxguitar/tuxguitar.bin -Dtuxguitar.library.path=%{_libdir}/tuxguitar/plugins/" \$1 \ > tuxguitar ---------------------------------------------------- * Pre-shipped binaries - For safety I recommend to remove all .DS_Store files at %prep * %defattr - For %defattr, see my comment on another your review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review