Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462181 --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> 2008-09-28 03:52:07 EDT --- 1.) Sane description Please remove the first line of %description, you duplicate Summary: 2.) Dependencies on data package Shouldn't dependencies of data package on code and vice versa be versioned? 3.) Please do not do the following: find -name '*.c' -o -name '*.cpp' -exec sed -i 's:data/:%{_datadir}/%{name}/:g' datasrc/data.ds {} \; Replace that with a patch. 4.) Preserving a timestamp of readme.txt while doing the conversion to utf8 might be a good idea. 5.) Use macros consistently Replace %{buildroot} with $RPM_BUILD_ROOT (or the reverse). 6.) Launch server with server icon, and client with client icon You seem to have reversed the contents of the .desktop files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review