Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463400 --- Comment #2 from Orcan Ogetbil <orcanbahri@xxxxxxxxx> 2008-09-27 18:37:05 EDT --- Thanks for the review. I fixed everything you said. The ExclusiveArch isn't needed, I took it off. One little question about the optflags: I added $RPM_OPT_FLAGS to the 'make'. Is that enough? Here are the updated files: Spec URL: http://6mata.com:8014/xmmsctrl/xmmsctrl.spec SRPM URL: http://6mata.com:8014/xmmsctrl/xmmsctrl-1.8-3.fc9.src.rpm Let me know if there's anything else to change. %changelog * Sat Sep 27 2008 Orcan Ogetbil <orcanbahri[AT]yahoo[DOT]com> - 1.8-3 - Added DistTag - Removed ExclusiveArch - Changed 0444 file permissions to 0644 - Changed %%defattr to (-,root,root,-) - Honored Fedora specific compilation flags - Support parallel make -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review