Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=451189 --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-26 14:49:30 EDT --- Created an attachment (id=317827) --> (https://bugzilla.redhat.com/attachment.cgi?id=317827) patch to honor cflags correctly For 2.3.2-0.3.a8 * spec file name - First of all, the name of the spec file should be "rancid.spec" * About optflags issue - Applying the patch attached will solve this issue. * SourceURL - Source0 must be written with full URL: https://fedoraproject.org/wiki/Packaging/SourceURL * Perl module dependency - The explicit dependencies perl(LockFile::Simple), perl(Mail::Mailer) can be removed. These dependencies are automatically found and added to binary rpm by rpmbuild itself. * Macros - Please use macros for standard directories. /etc should be %{_sysconfdir}. * Timestamp - Please consider to use -------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" -------------------------------------------------------- to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Directory ownership issue - Again please check if all directories which are created when this rpm is installed are correctly owned by this package. For example, the directory %{_sysconfdir}/%{name}/, %{_datadir}/%{name}/ are not owned by any packages: https://fedoraproject.org/wiki/PackagingDrafts/UnownedDirectories#Common_Mistakes Then: * Namespace conflict in %_bindir - This package tries to install so many files under %_bindir, and some of the files have rather generic names (like {a,b,c,...}login). Please - Move files to the directory specific to this rpm (e.g. %{_libdir}/%{name}) - Or rename binaries so that there names can easily be distinguished from binaries from other packages (like rancid-alogin or so) to avoid namespace conflict. Currently I have: ---------------------------------------------------------- # LANG=C rpm -ivh rancid-2.3.2-0.3.a8.fc10.1.i386.rpm Preparing... ########################################### [100%] file /usr/bin/par from install of rancid-2.3.2-0.3.a8.fc10.1.i386 conflicts with file from package par2cmdline-0.4-14.fc9.i386 ---------------------------------------------------------- Note that I have not installed the rebuilt binary rpm yet because of this conflict. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review