[Bug 462250] Review Request: Pmw - python megawidgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462250


Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka@xxxxxxxxxxxxxxxxxxx




--- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2008-09-26 03:01:01 EDT ---
Some notes.

* Build failure
  - Your srpm does not build:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=843287
    * At least python is needed for BuildRequires
    * Also even after python is added to BuildRequires the build fails (on
F-9+) like:
----------------------------------------------------------------
error: Installed (but unpackaged) file(s) found:
   /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info


RPM build errors:
    user fenn does not exist - using root
    Installed (but unpackaged) file(s) found:
   /usr/lib/python2.5/site-packages/Pmw-1.3.2-py2.5.egg-info
-----------------------------------------------------------------

* Redundant definition macro
  - %python_sitearch is used nowhere
  - Also it is not needed to define %version, %release macro explicitly.

* Source URL
  - %SOURCE must be written with full URL:
    https://fedoraproject.org/wiki/Packaging/SourceURL

* The line
-----------------------------------------------------------------
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
-----------------------------------------------------------------
  - is not needed. You define $RPM_BUILD_ROOT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]