Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460000 --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-26 02:27:57 EDT --- Two issues. * Macros in comment -------------------------------------------------------------------- # parallel make fails with make %{?_smp_mflags} -------------------------------------------------------------------- - In comments or %changelog, use %% instead of % to make it ensure that macros are not expanded. * build failure - Unfortunately now build fails on dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=844844 With the following change build seems to succeed (on dist-f10 and dist-f9-updates-candidate) --------------------------------------------------------------------- %build ./autogen.sh export JAVA_HOME=%{java_home} %configure # parallel make fails with make %%{?_smp_mflags} make --------------------------------------------------------------------- Note that you can find out how %java_home is determined by $ rpm --showrc Now this package itself is okay, so ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on: http://fedoraproject.org/PackageReviewStatus/NEW.html (NOTE: please don't choose "Merge Review") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------- For your case I found two other review requests by you (bug 454667, bug 455426). About these 2 review requests: - bug 454667 is currently blocked by legal issue, so I don't want to check this. - bug 455426 has several issues So I will postpone the approval of this package until you do a pre-review of other person's review request or you update bug 455426 (I will comment on bug 455426) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review