Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463766 --- Comment #1 from Dan Horák <dan@xxxxxxxx> 2008-09-25 09:58:11 EDT --- formal review is here, see the notes below: OK source files match upstream: 49d8d695510b1a92ad65f48a76107c448fcf5dc1 Wx-Perl-Dialog-0.01.tar.gz OK package meets naming and versioning guidelines. OK* specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). N/A debuginfo package looks complete. BAD rpmlint is silent. BAD final provides and requires look sane. BAD %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - update the Description to be more descriptive (see Dialog.pm) :-) - rpmlint warns about non-executable scripts at /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Wx-Perl-Dialog/* - at least the explicit Requires: perl(Wx) is redundant - the test requires running X to be useful (see build.log), so you should disable the %check section - the binary package contains /usr/lib/perl5/vendor_perl/5.10.0/auto/share/dist/Wx-Perl-Dialog/* and at least the /usr/lib/perl5/vendor_perl/5.10.0/auto directory is owned by perl itself - should be the files packaged and what about the directory ownership -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review