Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463764 --- Comment #1 from Matej Cepl <mcepl@xxxxxxxxxx> 2008-09-24 16:16:08 EDT --- + GOOD: rpmlint is silent on both source and binary package. + GOOD: The package is named according to the Package Naming Guidelines . + GOOD: The spec file name matches the base package %{name}, in the format %{name}.spec. - BAD: The package meets the Packaging Guidelines . * https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs there is no email address in %changelog -- all required formats of the changelog record include email address + GOOD: The package is licensed with a Fedora approved license and meet the Licensing Guidelines . + GOOD: The License field in the package spec file matches the actual license. + GOOD: LICENSE file is in %doc. + GOOD: The spec file is written in American English. + GOOD: The spec file for the package is legible. + MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. 3612558b4f285315d7c36668df96f254 Module-Manifest-0.03.tar.gz + MUST: The package successfully compiles and build into binary rpms on at least one supported architecture. Koji scratch build is http://koji.fedoraproject.org/koji/taskinfo?taskID=842686 + MUST: noarch, so it compiles everywhere. + MUST: All build dependencies are listed in BuildRequires. + MUST: The spec file MUST handle locales properly. No locale support. + MUST: no libraries + MUST: not relocatable + MUST: A package owns all directories that it creates. Follows perl guidelines. + MUST: A package must not contain any duplicate files in the %files listing. + MUST: Permissions on files must be set properly. + MUST: Each package have a %clean section. + MUST: Each package consistently use macros. + MUST: The package contains code, or permissable content. + MUST: No large documentation files, so no a -doc subpackage. + MUST: Files registered in %doc does not affect the runtime of the application. + MUST: No header files. + MUST: No static libraries. + MUST: No pkgconfig(.pc) files. + MUST: The package does not contain library files with a suffix. + MUST: No devel packages. + MUST: No .la libtool archives. + MUST: Packages does not contain GUI applications. + MUST: Packages does not own files or directories owned by other packages. + MUST: Runs rm -rf $RPM_BUILD_ROOT in %install + MUST: All filenames in rpm packages are valid UTF-8. + SHOULD: Includes license text. Attaching patch for the SPEC file -- when this is applied, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review