[Bug 461131] Review Request: sim - Simple Instant Messenger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #23 from Pavel Alexeev <pahan@xxxxxxxxxxxxxxx>  2008-09-24 13:36:22 EDT ---
(In reply to comment #21)
> rpmlint find some problems:
> sim.i386: E: zero-length /usr/share/doc/sim-0.9.5/AUTHORS
> You can remove AUTHORS from rpm, before packaging.
Please see discussion about it from comment #2 of this review. We make decision
leave it in package because it is upstream file and it may be filled in future.

Do you have another opinion?

> sim.i386: W: incoherent-version-in-changelog 0.9.5-0.4.20080923svn2261rev
> 0.9.5-0.3.20080923svn2261rev
> You've forgotten change release macron in the head of specfile.
Excuse me, what??? I'm not see this:
$ rpmlint sim-0.9.5-0.3.20080923svn2261rev.src.rpm
sim.src:131: W: macro-in-%changelog _datadir
sim.src:134: W: macro-in-%changelog _libdir
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpm -q rpmlint
rpmlint-0.84-2.fc10.noarch

About prerelease naming package my question leaved without answer, so, you are
think it is not correct version-release "0.9.5-0.4.20080923svn2261rev"?

In any case, I think it fixed now. Please check.

> sim.src:131: W: macro-in-%changelog _datadir
> sim.src:134: W: macro-in-%changelog _libdir
> The macro in changelog shouldn't be used.
Ok, this is my inadvertence. Fixed.

(In reply to comment #22)
> Source should be changed on something which could be downloaded from home page
> of project.
What should be here in case of SVN build (svn checkout, no source download from
upstrim)??


http://hubbitus.net.ru/rpm/Fedora9/sim/sim-0.9.5-0.5.20080923svn2261rev.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]