Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459908 --- Comment #23 from Sylvain Beucler <beuc@xxxxxxxx> 2008-09-23 17:12:28 EDT --- (In reply to comment #20) > For 1.08.20080920-1: > > * Dependency between subpackages > - Generally speaking, dependencies between packages generated from > the same srpm must be EVR (Epoch-Version-Release) specific. > (i.e. freedink must have "freedink-engine = %{version}-%{release}) OK, fixed. I have a question: the 'freedink' package is built as 'i386' instead of 'noarch' (E: no-binary). I couldn't find a way to use a different BuildArch for the 2 packages though. > * %fedora_version > - is not defined. Perhaps you want to use %{?fedora}. Yes indeed. (I had copied this one from a .spec from another project, but it was actually meant for the opensuse build service, with other variables) > * BuildRequires > - build.log shows: > ---------------------------------------------------- > 124 checking for help2man... > 125 no > 126 configure: WARNING: You need to install help2man > ---------------------------------------------------- > Perhaps "BuildRequires: help2man" is needed. I clarified this in Git, it's a developer tool. The build system takes care of pregenerating man pages to avoid the 'help2man' dependency. > * Timestamps > - Please consider to use > ---------------------------------------------------- > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > ---------------------------------------------------- > to keep timestamps as much as possible. This method > usually works for Makefiles generated from recent > autotools Did so. > * Desktop files > - must be treated by desktop-file-{install,validate}: > > https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Done too. > By the way I tried to play freedink but my mouse pointer does not > seem to be recognized. Hmmm, is there anything special about your mouse? Is it under X11? You mean you can't move the mouse in the intro screen, is that right? I didn't have this problem yet, either it's a SDL bug, either it's the way I continuously recenter the mouse to get relative motions without letting the mouse get out of the window. Here are the new files: http://www.freedink.org/snapshots/fedora-review/freedink.spec http://www.freedink.org/snapshots/fedora-review/freedink-1.08.20080920-1.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review