Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459916 --- Comment #18 from Sylvain Beucler <beuc@xxxxxxxx> 2008-09-23 16:35:49 EDT --- (In reply to comment #14) > For 3.2-1 > > * Source0 > - seems 404. Fixed with new proper release. > * Dependency > - build.log shows: > ------------------------------------------------------ > 140 checking for wxglade... > 141 no > 142 configure: WARNING: You need to install wxglade > ------------------------------------------------------ > Perhaps "Requires: wxGlade" is needed? Clarified, this is a developer tool, only needed if you want to modify the UI files. > * Timestamps > - Please consider to use > ------------------------------------------------------ > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > ------------------------------------------------------ > to keep timestamps on installed files as much as possible. > This method usually works for Makefiles generated from > recent autotools. Done. > * Desktop file > - Any installed desktop files must be treated by > desktop-file-{install,validate}: > > https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Done. > * Scriptlets > - As a XML file is installed under %_datadir/mime/packages/, > mime data must be updated: > https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo Done. > * Documents > - Please add "ChangeLog" to %doc. Also, doc/dfarc.txt can be added > to %doc. I added ChangeLog. I didn't feel like including doc/dfarc.txt since it's developer information. > * Directory ownership issue > - %_datadir/icons/hicolor (and directories under this directories) are > already owned by hicolor-icon-theme and should not be owned by > this package. I think I fixed it by being more precise in the %files section: -%{_datadir}/icons/* +%{_datadir}/icons/hicolor/32x32/mimetypes/* > * %changelog format > --------------------------------------------------------- > freedink-dfarc.i386: W: incoherent-version-in-changelog 3.2 3.2-1.fc10 > --------------------------------------------------------- > - %changelog should contain EVR (Epoch-Version-Release) information > (not just Epoch-Version) (%dist information can be removed): > https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs Oops, fixed. http://www.freedink.org/snapshots/fedora-review/freedink-dfarc.spec http://www.freedink.org/snapshots/fedora-review/freedink-dfarc-3.2.1-1.fc8.src.rpm By the way, under F9 and mock, I keep getting rpmlint errors about g+w directories: freedink-dfarc.i386: E: non-standard-dir-perm /usr/share/doc/freedink-dfarc-3.2.1 02755 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. Any clue? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review