Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462982 manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #9 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2008-09-23 10:47:36 EDT --- I'll take care of this. For the moment there are a few issues: 1. major one: during compilation the mandatory gcc flags as imposed by Fedora (http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags) are not used. Instead compilation is done with -Wall -O6 -fomit-frame-pointer 2. minor issues: - I see no point in applying all the debian patches. We have no need for the content of the debian folder. You do not package it, which is OK, but I would have adjusted the patches to better fit Fedora. Not a blocker, feel free to leave it as it is. - there is a missing "s" in the Summary(fr) line (des bande -> des bandes) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review