[Bug 456190] Review Request: dosemu - dos emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456190





--- Comment #14 from Andrea Musuruane <musuruan@xxxxxxxxx>  2008-09-23 05:03:21 EDT ---
(In reply to comment #13)
> hi, I am not sure how this should be done, iconv needs to know what the file
> format is, and there doesnt seem to be any type that matches:
> 
> troff or preprocessor input text
> ASCII Pascal program text
> Non-ISO extended-ASCII English text, with LF, NEL line terminators

I haven't looked at the file but most files are usually ISO 8859-1. Russian
ones should be ISO 8859-5. Try to convert them and see if the results make
sense.

> The other warnings might be ok, I don't know I can set the symbolic links with
> a relative path, and dosemu would never run chroot anyways.

Ehm... no, I don't think they are OK. Search for a solution in Fedora CVS.

Moreover, Source URL is missing:
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

I read in COPYING.DOSEMU:

     Parts of the code not covered by the GPL are marked explicitly
     within the code, and the copyrights are also at the end of this
     file. The rest of the code is covered by the GPL.

Therefore you should update License tag accordingly:
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

Bye,

Andrea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]