Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459908 --- Comment #20 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-22 13:34:03 EDT --- For 1.08.20080920-1: * Dependency between subpackages - Generally speaking, dependencies between packages generated from the same srpm must be EVR (Epoch-Version-Release) specific. (i.e. freedink must have "freedink-engine = %{version}-%{release}) * %fedora_version - is not defined. Perhaps you want to use %{?fedora}. * BuildRequires - build.log shows: ---------------------------------------------------- 124 checking for help2man... 125 no 126 configure: WARNING: You need to install help2man ---------------------------------------------------- Perhaps "BuildRequires: help2man" is needed. * Timestamps - Please consider to use ---------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------- to keep timestamps as much as possible. This method usually works for Makefiles generated from recent autotools * Desktop files - must be treated by desktop-file-{install,validate}: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage By the way I tried to play freedink but my mouse pointer does not seem to be recognized. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review