Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463133 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-09-22 03:48:14 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=835671 - rpmlint is silent NOT for SRPM and for RPM. perl-Log-Dispatch-Perl.noarch: W: invalid-license CHECK perl-Log-Dispatch-Perl.src: W: invalid-license CHECK ==> You should change it to "GPL+ or Artistic" + source files match upstream url e23dcef192fc33f0213e4c72553b76a7 Log-Dispatch-Perl-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful! Files=1, Tests=21, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.04 cusr 0.00 csys = 0.06 CPU) + Package perl-Log-Dispatch-Perl-0.03-1.fc10 => Provides: perl(Log::Dispatch::Perl) = 0.03 Requires: perl(base) perl(strict) Suggestions:- I see license for this package is "GPL+ or Artistic", but you listed as CHECK(GPL+ or Artistic) ? Do you see any issues with license here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review