Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459916 --- Comment #14 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-21 13:13:51 EDT --- For 3.2-1 * Source0 - seems 404. * Dependency - build.log shows: ------------------------------------------------------ 140 checking for wxglade... 141 no 142 configure: WARNING: You need to install wxglade ------------------------------------------------------ Perhaps "Requires: wxGlade" is needed? * Timestamps - Please consider to use ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated from recent autotools. * Desktop file - Any installed desktop files must be treated by desktop-file-{install,validate}: https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage * Scriptlets - As a XML file is installed under %_datadir/mime/packages/, mime data must be updated: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo * Documents - Please add "ChangeLog" to %doc. Also, doc/dfarc.txt can be added to %doc. * Directory ownership issue - %_datadir/icons/hicolor (and directories under this directories) are already owned by hicolor-icon-theme and should not be owned by this package. * %changelog format --------------------------------------------------------- freedink-dfarc.i386: W: incoherent-version-in-changelog 3.2 3.2-1.fc10 --------------------------------------------------------- - %changelog should contain EVR (Epoch-Version-Release) information (not just Epoch-Version) (%dist information can be removed): https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review