Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225706 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|twaugh@xxxxxxxxxx |ville.skytta@xxxxxx --- Comment #7 from Ville Skyttä <ville.skytta@xxxxxx> 2008-09-20 08:06:21 EDT --- I think 3.1-33 looks fine, the only things I'd change is move "make clean" from %build to %prep, and add a comment about missing upstream somewhere in the top of the specfile. But those are cosmetic, approved as is. Feel free to close this bug when you've either done the above or decided not to bother with them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review