Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458952 Jan ONDREJ <ondrejj@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(lemenkov@xxxxxxxx | |m) --- Comment #5 from Jan ONDREJ <ondrejj@xxxxxxxxxx> 2008-09-20 02:28:45 EDT --- - MUST: rpmlint must be run on every package. [ondrejj@builder tmp]$ rpmlint sems-1.0.0-0.5.svn.fc9.src.rpm sems.src:295: E: files-attr-not-set sems.src:296: E: files-attr-not-set sems.src:297: E: files-attr-not-set sems.src:298: E: files-attr-not-set sems.src:299: E: files-attr-not-set sems.src: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1) 1 packages and 0 specfiles checked; 5 errors, 1 warnings. - SHOULD: The package should compile and build into binary rpms on all supported architectures. Package does not build on devel.x86_64! Part of error: Error: Installed (but unpackaged) file(s) found: /usr/lib/sems/audio/annrecorder/beep.wav RPM build errors: File not found: /var/tmp/sems-1.0.0-0.5.svn.fc9-root-mockbuild/usr/lib64/sems/audio File not found: /var/tmp/sems-1.0.0-0.5.svn.fc9-root-mockbuild/usr/lib64/sems/audio/ann_b2b File not found: /var/tmp/sems-1.0.0-0.5.svn.fc9-root-mockbuild/usr/lib64/sems/audio/announcement - MUST: A package must own all directories that it creates. Directories without ownership: %config(noreplace) %{_sysconfdir}/sems/etc/ %{_libdir}/sems/audio/annrecorder/ %{_libdir}/sems/audio/conference/ %{_libdir}/sems/audio/voicebox/ %{_libdir}/sems/audio/voicemail/ %{_libdir}/sems/audio/webconference/ %{_libdir}/sems/audio/mailbox/ %{_libdir}/sems/ivr/imap_mailbox/ %{_libdir}/sems/audio/pincollect/ - Not in packaging guidelines, only mi opinion: I think a "." at end of sentences in description (not summary) is nice. Also please update summary to at least for example "SEMS mailbox module". Same problem for description. I still do not assing this package to me. My current free time is limited, so I leave this package to anyone, but if still no review I will check it again. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review