[Bug 462074] Review Request: gnome-applet-jalali-calendar - Jalali calendar panel applet for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462074


Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mtasaka@xxxxxxxxxxxxxxxxxxx




--- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2008-09-19 14:28:23 EDT ---
Well, for 1.6.5-1:

* %{_libdir} in noarch package
--------------------------------------------
.src:40: W: libdir-macro-in-noarch-package %{_libdir}/bonobo/servers/*
--------------------------------------------
   - The explanation of this is shown by
     $ rpmlint -I libdir-macro-in-noarch-package . Generally
     this warning means that

     * If you rebuild this on i386, some files are installed under
       /usr/lib
     * On x86_64, they are put under /usr/lib64
     * However as this package is marked as _noarch_, the result
       binary rpm should be the same regardless of the architecture used
       when rebuilding

     So for noarch packages macros like %_libdir or %_lib should not
     be used. For the case of this package AFAIK even on 64 arch
     bonobo server picks up server files under %_prefix/lib (see:
     https://bugzilla.redhat.com/show_bug.cgi?id=426149#c3 )

* python related dependency
  - Please examine python module related dependencies for this package
    and add them as Requires.
    ! Example:
      /usr/share/jalali-calendar/jcalendar.py contains the line:
---------------------------------------------
    25  import pygtk
    26  pygtk.require('2.0')
---------------------------------------------
      This means that this package should have "Requires: pygtk2".

    Note that such python related dependencies are not detected
    automatically by rpmbuild. To find out these dependencies, I usually
    try like below:
---------------------------------------------
$ grep -h 'import ' /usr/share/jalali-calendar/*py | sort | uniq
from gtk import gdk
from string import strip, lower
from xml.dom.minidom import getDOMImplementation, parse
from xml.parsers.expat import ExpatError
import birthdaydialog
import cairo
.......
-----------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]