[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458054





--- Comment #2 from David Carter <dcarter@xxxxxxxxxxxxxxxx>  2008-09-19 12:51:52 EDT ---
Thanks for the review. I'm already in the midst of preparing an updated
version, and most of your comments have already been incorporated. I need some
advice from the selinux guys before the directory setup is complete, as some
temp files may have to move out of temp, so it may be a couple of days before I
get an updated version ready for review.

Some comments...

arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4_null.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

These are needed in the non-devel versions, as many ARM programs are designed
to dynamically link against these libraries. An example is the apache mod_arm4
module, which I'll be packaging as soon as I get the selinux issues worked out
:)

I've moved the offending directories from /var/arm4 to /var/lib/arm4.

There is documentation for the devel and java packages that will be included.

I'm updating the start up file as you requested.

Finally, if you're reviewing this, you may want to consider reviewing 458279
which is a python module related to this.

Thanks for your efforts!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]