Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462357 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-19 12:00:59 EDT --- For 12.1.1-1: * License tag - Your license analysis is correct. Then, you use "License: LGPLv2+ and GPLv2+" as license tag. This tag is inherited by all subpackages (i.e. rpm -qi rcsslogplayer-devel shows this license tag). So you have to write explicitly "License: LGPLv2+" in -devel subpackage. * Build Failure - As said above, please use -------------------------------------------------- %configure --with-qt4-moc=%{_bindir}/moc-qt4 -------------------------------------------------- to fix build failure (successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=833207 ) * Desktop file -------------------------------------------------- 1572 + desktop-file-install --vendor=fedora --dir=/builddir/build/BUILDROOT/rcsslogplayer-12.1.1-1.1.fc10.i386//usr/share/applications /builddir/build/SOURCES/rcsslogplayer.desktop 1573 /builddir/build/SOURCES/rcsslogplayer.desktop: key "Categories" is a list and does not have a semicolon as trailing character, fixing -------------------------------------------------- - The category should be: -------------------------------------------------- Categories=Education;Science;Robotics; -------------------------------------------------- + build successful with modification + spec description good + tarball matches upstream + can be installed + seems to work ---------------------------------------------------------- This package (rcsslogplayer) is APPROVED by mtasaka ---------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review