[Bug 462638] Review Request: anaconda-yum-plugins - Package containing yum plugins for anaconda and preupgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462638


Chris Lumens <clumens@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(clumens@xxxxxxxxx |
                   |m)                          |




--- Comment #2 from Chris Lumens <clumens@xxxxxxxxxx>  2008-09-17 17:12:53 EDT ---
> anaconda-yum-plugins.noarch: W: no-documentation

Done.

> anaconda-yum-plugins.noarch: W: non-conffile-in-etc
> /etc/yum/pluginconf.d/blacklist.conf
> anaconda-yum-plugins.noarch: W: non-conffile-in-etc
> /etc/yum/pluginconf.d/whiteout.conf

Done.

> anaconda-yum-plugins.noarch: E: non-executable-script
> /usr/lib/yum-plugins/blacklist.py 0644
> anaconda-yum-plugins.noarch: E: non-executable-script
> /usr/lib/yum-plugins/whiteout.py 0644

It's complaining because the plugins are 0644, but start with
#!/usr/bin/python.  That's pretty picky, but done.

> anaconda-yum-plugins.noarch: E: only-non-binary-in-usr-lib

Probably the same.

> Package guidelines say this should be %{_libdir}/yum-plugins/*

Yes they usually should, but I don't know of any yum plugins that drop files
into /usr/lib64/yum-plugins.  So this one is probably okay as-is.

> anaconda-yum-plugins.src: W: strange-permission anaconda-yum-plugins.spec 0600

This should be fixed up by running it through the build system instead of me
just doing rpmbuild -ta on the tarball.

I'll update the spec and srpm at the previous location.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]