Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225974 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx --- Comment #2 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-09-17 15:48:30 EDT --- rpmlint on SRPM: krb5.src:109: E: prereq-use grep, info, sh-utils, /sbin/install-info The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:110: E: buildprereq-use autoconf, bison, e2fsprogs-devel >= 1.35, flex, gawk The use of BuildPreReq is deprecated, build dependencies are always required before a package can be built. Use plain BuildRequires instead. krb5.src:111: E: buildprereq-use gzip, ncurses-devel, rsh, texinfo, texinfo-tex, tar The use of BuildPreReq is deprecated, build dependencies are always required before a package can be built. Use plain BuildRequires instead. krb5.src:144: E: prereq-use grep, /sbin/ldconfig, sh-utils The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:145: W: unversioned-explicit-obsoletes krb5-configs The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. krb5.src:156: E: prereq-use grep, /sbin/install-info, /bin/sh, sh-utils, /sbin/chkconfig The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:181: E: prereq-use grep, /sbin/install-info, /bin/sh, sh-utils The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:196: E: prereq-use grep, /sbin/install-info, /bin/sh, sh-utils The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:211: E: prereq-use grep, /sbin/install-info, /bin/sh, sh-utils The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. krb5.src:1076: W: macro-in-%changelog _var Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. krb5.src:1113: W: macro-in-%changelog post Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. krb5.src:1191: W: macro-in-%changelog _var Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. krb5.src:1237: W: macro-in-%changelog version Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. Fix. krb5.src:1399: E: use-of-RPM_SOURCE_DIR You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. Fix or explain need in spec. krb5.src:1490: W: make-check-outside-check-section : make check TMPDIR=%{_tmppath} Make check or other automated regression test should be run in %check, as they can be disabled with a rpm macro for short circuiting purposes. Fix or explain placement in spec. krb5.src: W: mixed-use-of-spaces-and-tabs (spaces: line 325, tab: line 1400) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Fix. krb5.src: W: patch-not-applied Patch26: krb5-1.3.2-efence.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. krb5.src: W: patch-not-applied Patch55: krb5-1.6.1-empty.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. krb5.src: W: patch-not-applied Patch57: krb5-1.6.2-login_chdir.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. krb5.src: W: patch-not-applied Patch64: krb5-ok-as-delegate.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. krb5.src: W: patch-not-applied Patch70: krb5-trunk-kpasswd_tcp2.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. Apply, drop or explain in spec. krb5.src: W: summary-ended-with-dot The Kerberos network authentication system. Summary ends with a dot. Fix. krb5.src: W: strange-permission krb5kdc.init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission krb5.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission kpropd.init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission krb524d.init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission kadmind.init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission krb5.csh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. krb5.src: W: strange-permission krb5-tex-pdf.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Fix or document in spec. rpmlint on RPMS: krb5-devel.i386: W: spurious-executable-perm /usr/share/doc/krb5-devel-1.6.3/krb5-protocol/draft-jaganathan-rc4-hmac-03.txt The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. krb5-devel.i386: W: summary-ended-with-dot Development files needed to compile Kerberos 5 programs. Summary ends with a dot. Fix. krb5-devel.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Probably fine. krb5-libs.i386: W: hidden-file-or-dir /usr/kerberos/man/man5/.k5login.5.gz The file or directory is hidden. You should see if this is normal, and delete it from the package if not. ??????????? krb5-libs.i386: W: summary-ended-with-dot The shared libraries used by Kerberos 5. Summary ends with a dot. krb5-libs.i386: W: obsolete-not-provided krb5-configs If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides. Fix. krb5-libs.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Fine. krb5-pkinit-openssl.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Fix if possible. krb5-pkinit-openssl.i386: W: summary-ended-with-dot The PKINIT module for Kerberos 5. Summary ends with a dot. Fix. krb5-server.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/krb524 Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. krb5-server.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/krb5kdc Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. krb5-server.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/kadmin Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. krb5-server.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/kprop Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. I suspect this is necessary, but you might want to comment on why in the spec. krb5-server.i386: W: summary-ended-with-dot The KDC and related programs for Kerberos 5. Summary ends with a dot. Fix. krb5-server.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/kadmin A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here krb5-server.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/kprop A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here krb5-server.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/krb524 A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here krb5-server.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/krb5kdc A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here Fix, unless breakage would ensue. krb5-server.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. krb5-server.i386: W: non-standard-dir-in-var kerberos Your package is creating a non-standard subdirectory in /var. The standard directories are: account, lib, cache, crash, games, lock, log, opt, run, spool, state, tmp, yp, www, ftp. Fine. krb5-server.i386: W: no-reload-entry /etc/rc.d/init.d/krb524 In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality. krb5-server.i386: W: no-reload-entry /etc/rc.d/init.d/kprop In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality. Fix. If the software doesn't support it, just mirror the restart entry. krb5-server-ldap.i386: W: devel-file-in-non-devel-package /usr/lib/libkdb_ldap.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. Fine. krb5-server-ldap.i386: E: library-without-ldconfig-postin /usr/lib/libkdb_ldap.so.1.0 This package contains a library and provides no %post scriptlet containing a call to ldconfig. krb5-server-ldap.i386: E: library-without-ldconfig-postun /usr/lib/libkdb_ldap.so.1.0 This package contains a library and provides no %postun scriptlet containing a call to ldconfig. Probably needs fixing. krb5-server-ldap.i386: W: summary-ended-with-dot The LDAP storage plugin for the Kerberos 5 KDC. Summary ends with a dot. Fix. krb5-server-ldap.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Fix. krb5-workstation.i386: E: setuid-binary /usr/kerberos/bin/ksu root 04755 The file is setuid, this may be dangerous, especially if this file is setuid root. Necessary, I suspect. krb5-workstation.i386: E: non-standard-executable-perm /usr/kerberos/bin/ksu 04755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. See above. krb5-workstation.i386: W: summary-ended-with-dot Kerberos 5 programs for use on workstations. Summary ends with a dot. Fix. krb5-workstation.i386: W: unstripped-binary-or-object /usr/kerberos/bin/ksu Fix if possible. krb5-workstation.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Fine. krb5-workstation-clients.i386: E: info-files-without-install-info-postin /usr/share/info/krb5-user.info.gz This package contains info files and provides no %post scriptlet containing a call to install-info. krb5-workstation-clients.i386: E: info-files-without-install-info-postun /usr/share/info/krb5-user.info.gz This package contains info files and provides no %postun scriptlet containing a call to install-info. Fix. krb5-workstation-clients.i386: W: summary-ended-with-dot Kerberos 5 clients for use on workstations. Summary ends with a dot. Fix. krb5-workstation-clients.i386: W: unstripped-binary-or-object /usr/kerberos/bin/v4rcp Fix if possible. krb5-workstation-clients.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Fine. krb5-workstation-servers.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/krb524 Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. Probably fine. krb5-workstation-servers.i386: W: summary-ended-with-dot Kerberos 5 servers for use on workstations. Summary ends with a dot. Fix. krb5-workstation-servers.i386: W: unstripped-binary-or-object /usr/kerberos/bin/v4rcp krb5-workstation-servers.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/krb524 A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here Fix if possible. krb5-workstation-servers.i386: W: non-standard-dir-in-usr kerberos Your package is creating a non-standard subdirectory in /usr. The standard directories are: X11R6, X386, bin, games, include, lib, lib64, local, sbin, share, src, spool, tmp. Fine. krb5-workstation-servers.i386: E: postin-without-chkconfig /etc/rc.d/init.d/krb524 The package contains an init script but doesn't call chkconfig in its %post. krb5-workstation-servers.i386: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/krb524 The package contains an init script but doesn't contain a %preun with a call to chkconfig. Probably needs fixing. krb5-workstation-servers.i386: W: no-reload-entry /etc/rc.d/init.d/krb524 In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality. See above. krb5-workstation-servers.i386: W: incoherent-init-script-name krb524 The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. Fix or explain. Source: tag lacks a URL, so I can't check the md5sum. Working on a local mock build to test BuildRequires. I'll post back when it's done. Other than the above, full review is OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review