Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=441378 --- Comment #22 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2008-09-16 14:57:25 EDT --- > a) perl has become an useless BR, because it is brought in by perl(Grammar); perl(Grammar) is req, not br? perl is not used in building anyway, removed. > b) glibc-common is definitely not needed as BR; needed for iconv (or do you mean glibc-common is always available?) > c) you use lots of macros in the {__xx} form, but "mv" is used as such. Nor a > blocker neither incorrect, but not consistent from a stylish point of view. fixed. > d) in the lines > %{__rm} -rf in lib/{CGI,Config,Digest,JSON} > %{__rm} -rf in lib/{SNMP_Session,SNMP_util,BER,JSON}.pm cut-n-paste error, fixed. > Now the preamble of the question: as far as I can see, the newer rpm (2.4.2-3) > removed the requires for > perl(B) > perl(CGI::Session::Driver) > perl(CGI::Session::Driver::DBI) > perl(CGI::Session::ErrorHandler) > perl(Class::Struct) > perl(DBD::Pg) > perl(DB_File) > perl(DBI) > perl(Digest::HMAC) > perl(Digest::SHA1) > perl(File::Spec) > perl(FreezeThaw) > perl(overload) > perl(Scalar::Util) > perl(Test::More) > > I do not have the infrastructure on which to test and my perl-fu is rather > weak, so I have to rely to an answer from others: is all the previous > functionality preserved ? With all the external modules removed this is not surprising, these requirements are now pushed into the modules smokeping depends on (I hope :-). spec: http://terjeros.fedorapeople.org/smokeping/smokeping.spec srpm: http://koji.fedoraproject.org/koji/getfile?taskID=828581&name=smokeping-2.4.2-4.fc10.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=828580 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review