Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226161 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx --- Comment #1 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-09-16 12:21:58 EDT --- rpmlint on SRPM: mrtg.src:22: E: prereq-use vixie-cron The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. mrtg.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 44) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Fix. mrtg.src: W: strange-permission filter-requires-mrtg.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. mrtg.src: W: strange-permission filter-provides-mrtg.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. What are these about? If they're good this way, please document what they do in the spec. rpmlint on RPMS: mrtg.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/mrtg-2.16.2/contrib/whodo/GIFgraph/GIFgraph/samples/sample54.dat mrtg.i386: W: file-not-utf8 /usr/share/doc/mrtg-2.16.2/CHANGES Tons of this all over the docs. Fix. mrtg.i386: E: wrong-script-interpreter /usr/share/doc/mrtg-2.16.2/contrib/TCH/dualpri.pl "c:\perl\bin" This script uses an incorrect interpreter. mrtg.i386: E: wrong-script-interpreter /usr/share/doc/mrtg-2.16.2/contrib/TCH/hiperdsp.pl "c:\perl\bin" This script uses an incorrect interpreter. mrtg.i386: E: wrong-script-interpreter /usr/share/doc/mrtg-2.16.2/contrib/TCH/dualt1.pl "c:\perl\bin" This script uses an incorrect interpreter. mrtg.i386: E: wrong-script-interpreter /usr/share/doc/mrtg-2.16.2/contrib/cfgmaker_cisco/cfgmaker.cisco "/pkg/gnu/bin/perl" This script uses an incorrect interpreter. mrtg.i386: E: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. mrtg.i386: W: dangerous-command-in-%trigger rm Fix. License tag should by GPLv2+. Otherwise, full review looks good, no other blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review