[Bug 458030] Review Request: avogadro - Avogadro is an advanced Molecular editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458030





--- Comment #5 from Thorsten Leemhuis <fedora@xxxxxxxxxxxxx>  2008-09-14 03:55:09 EDT ---
= general =

- rpmlint mentions
 >  avogadro.src: W: strange-permission avogadro-0.8.1.tar.bz2 0777
 please fix

 > avogadro-libs.x86_64: W: no-documentation
 > avogadro-devel.x86_64: W: no-documentation
 Can be ignored


- doesn't build in mock (and thus will faill in the Fedora buildsys):

 > /var/tmp/rpm-tmp.5185: line 37: desktop-file-install: command not found


- from mock right after the first cmake call:

 > -- docbook tools not found, doc targets disabled

Please check; docs should be shipped normally. Likely needs just a porper
BuildRequire as well


== libs subpackage ==

- Group should be "System Environment/Libraries"

== devel subpackage ==

- Change 
 > Requires:       %{name} = %{version}
to
 > Requires:       %{name}-libs = %{version}-%{release} 

== More Comments ==

Looks good otherwise. Once the above things are fixed I'll approve the package
and sponser you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]