Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461571 --- Comment #5 from Simon Schampijer <simon@xxxxxxxxxxxxx> 2008-09-13 06:42:08 EDT --- (In reply to comment #4) > Okay, going through to do a more complete review. > > * NEEDSWORK: The URL given for the tarball doesn't exist, it looks like Log-15 > never got uploaded? So can't verify against upstream source Sorry they are uploaded now. > * FYI: Please bump the release in the future when making changes, even as the > result of review comments Sure. > * FYI: Please request that upstream include a version of the GPL as COPYING > within their source tarball Done. > Builds fine in mock, rpmlint output has a few things which need fixing > > * sugar-log.noarch: E: zero-length Done. > /usr/share/sugar/activities/Log.activity/README > sugar-log.noarch: E: zero-length /usr/share/doc/sugar-log-15/README > > If it's empty, it's probably not worth including Removed from the sources. > * sugar-log.noarch: E: non-executable-script > /usr/share/sugar/activities/Log.activity/logviewer.py 0644 > sugar-log.noarch: E: non-executable-script > /usr/share/sugar/activities/Log.activity/logcollect.py 0644 > These should have the #!/usr/bin/python removed from the top if they're not > meant to be directly executed. Fixed. > * sugar-log.noarch: E: description-line-too-long Log is an activity for > developers to examine the log files that are generated by Done. > The description lines are supposed to be limited to 72 (iirc) characters > > * sugar-log.noarch: W: non-standard-group Sugar/Activities > > There's a bug tracking adding this as acceptable, so fine > > * sugar-log.noarch: E: incorrect-locale-subdir > /usr/share/locale/pseudo/LC_MESSAGES/org.laptop.Log.mo > > If this will be getting fixed up in a future sugar-toolkit, then I'm fine with > leaving the problem for now and it'll just get fixed up as things rebuild Yeah we just wait for another fix to get in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review