Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460000 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-12 12:09:17 EDT --- Some initial comments * Versioning https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages - Under your usage of macros, the version should be %{rel}.%{uprel}%{?dist} (Fedora specific release number comes first: this is for the safety of bumping release number) * License - For this package the license tag must be "LGPLv2+". * Vendor - Remove Vendor tag. This is automatically tagged on Fedora side. * precompiled binaries - The source tarball contains some precompiled binaries (mainly .jar Java archive), which must all be removed at %prep. https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software * %PATCH1 -------------------------------------------------------------- sed -e 's|@JNIPATH@|%{jni}|' %{PATCH1} | patch -p1 -------------------------------------------------------------- - Use "patch -s" (maybe you want to use "patch -s -b --suffix .p1") * configure -------------------------------------------------------------- CFLAGS="$RPM_OPT_FLAGS" LDFLAGS=-s ./configure --prefix=/usr -------------------------------------------------------------- - Just use %configure (please check what %configure does by $ rpm --eval %configure ) - Auto, automated stripping is forbidden. Stripping binaries must be done by /usr/lib/rpm/find-debuginfo.sh * parallel make - Support parallel make when possible. When it is impossible, add a comment in the spec file: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make * libtool .la files - should usually be removed. https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries * Directory ownership issue - The directory %_libdir/%name is not owned by any package. Please refer to https://fedoraproject.org/wiki/PackagingDrafts/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory * Documents - Please add the following files to %doc. --------------------------------------------------------------- AUTHORS COPYING ChangeLog --------------------------------------------------------------- * %changelog --------------------------------------------------------------- rxtx.i386: W: incoherent-version-in-changelog 2.1 2.1-7r2.1.fc10 --------------------------------------------------------------- - The number "2.1" is not sufficient in the %changelog. You should use "2.1-1.7r2", for example. Please refer to: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review