Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462043 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-12 10:32:54 EDT --- For 12.1.3-1: * License - I guess the license tag should "GPLv2+" * Some codes like coach_lang_tok.cpp are generated by bison/flex. Although bison has some exception term for GPL, for this package the original parser skeletons themselves are written under GPLv2+. * Requires - -gui subpackage usually must have EVR (epoch-version-release) specific dependency against main package, not just version specific. * %defattr - is missing on -gui subpackage. * modules - Usually "modules" (which are usually under %_libdir/%name) are dlopen()ed by the main binary as the names of XXXX.so, so usually symlinks to the modules like %_libdir/%name/XXX.so should not be -devel subpackage. Actually about rcsoccersim script, without -devel subpackage: ------------------------------------------------------ [tasaka1@localhost ~]$ ls -al /usr/lib/rcssserver/modules/libstdoutsaver* lrwxrwxrwx 1 root root 23 2008-09-12 22:26 /usr/lib/rcssserver/modules/libstdoutsaver.so.0 -> libstdoutsaver.so.0.0.0 -rwxr-xr-x 1 root root 21784 2008-09-12 16:38 /usr/lib/rcssserver/modules/libstdoutsaver.so.0.0.0 [tasaka1@localhost ~]$ rcssmodtest /usr/lib/rcssserver/modules/libstdoutsaver ; echo $? error: could not load /usr/lib/rcssserver/modules/libstdoutsaver error: /usr/lib/rcssserver/modules/libstdoutsaver.so: cannot open shared object file: No such file or directory 1 ------------------------------------------------------ * rcsoccersim script - src/rcsoccersim.in does not handle 64 bit arch issue correctly (@prefix@/lib or so won't work) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review