Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461077 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-11 13:57:40 EDT --- Some remarks: ! iconv script - Not a blocker, however would you write them shorter like below? ------------------------------------------------------- %setup -q for f in \ CHANGES COPYRIGHT TODO nxtvepg.1 do iconv -f ISO-8859-15 -t UTF-8 $f > $f.new touch -c -r $f $f.new mv -f $f.new $f done ------------------------------------------------------- * optflags - Fedora specific compilation flags are not correctly honored: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags You can check what flags are used by $ rpm --eval %optflags * app-defaults directory - I guess we should use %_datadir/X11/app-defaults as app-defaults directory * On my system %_sysconfdir/X11/app-defaults is not owned by any packages * Also there are no files under %_sysconfdir/X11/app-defaults * Desktop file ------------------------------------------------------- 206 + desktop-file-install --vendor=fedora --dir=/builddir/build/BUILDROOT/nxtvepg-2.8.0-2.fc10.i386/usr/share/applications /builddir/b uild/SOURCES/nxtvepg.desktop 207 /builddir/build/SOURCES/nxtvepg.desktop: key "Categories" is a list and does not have a semicolon as trailing character, fixing ------------------------------------------------------- - Category line should be "Categories=AudioVideo;". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review