Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452805 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2008-09-11 13:10:11 EDT --- REVIEW ========== Good: - rpmlint checks return: ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/ogre.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/resources.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/terrain.cfg Documented why you didn't do this, safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (f5d94ac46131bcf0bb7788e311331aac523287b8) - package compiles on devel (x86_64, koji scratch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file ok Nice job with this package, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review