[Bug 460886] Review Request: libnetdude - a libpcap trace file manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460886


Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian@xxxxxxxxxxxxxxxxx




--- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx>  2008-09-10 17:05:33 EDT ---
rpmlint says...
[rpm@laptop024 SRPMS]$ rpmlint libnetdude-0.11-1.src.rpm 
libnetdude.src:17: W: hardcoded-packager-tag Christian
libnetdude.src:19: W: hardcoded-prefix-tag %{prefix}
libnetdude.src:47: W: configure-without-libdir-spec
libnetdude.src: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Some quick comments on your spec:

- use macros
http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros

- Don't use tag 'Packager'

- The Tag 'Release' should incl. %{?dist} and bumped with every new version of
your spec file.

- %changelog, add version and release according the sample in the Package HowTo


More details can be found
http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]