Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-10 13:00:14 EDT --- Well, some quick notes for 0.3.0-2: * License - As far as I checked the whole codes, the license tag should be "GPLv2+ and LGPLv2+". * Groups - Is the Group tag "Development/Libraries" proper? (maybe "Development/Tools")? * ExcludeArch - Even on ppc this does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=817251 Some codes seems to be using heavily i386 dependent codes and perhaps this package only supports i386? * compilation flags, debug info - compilation flags "-O4 -fomit-frame-pointer -ffast-math" makes debugging very difficult and Fedora does not allow these flags. - Also, automated stripping of binaries is forbidden because this prevents from making correct debuginfo rpm. For example: ----------------------------------------------------------------- 425 make[1]: Entering directory `/builddir/build/BUILD/mlt-0.3.0/src/inigo' 426 install -d "/builddir/build/BUILDROOT/mlt-0.3.0-2.fc10.i386/usr/bin" 427 install -c -s -m 755 inigo "/builddir/build/BUILDROOT/mlt-0.3.0-2.fc10.i386/usr/bin" 428 make[1]: Leaving directory `/builddir/build/BUILD/mlt-0.3.0/src/inigo' ----------------------------------------------------------------- "install" command option "-s" must be removed. * %defattr - Now we recommend %defattr(-,root,root,-) * %doc - Perhaps "%doc docs/" (not %doc docs/*) is better (this keeps directory structure) * Directory ownership issue - The directory %_libdir/%name is not owned by any packages. ! By the way should files under %_libdir/%name really be in -devel subpackage? Usually these are modules of "main" binary and should not be in -devel subpackage. * rpmlint issue ------------------------------------------------------------------ mlt-devel.i386: W: executable-stack /usr/lib/mlt/libmltgtk2.so ------------------------------------------------------------------ - "rpmlint -I executable-stack" shows the explanation, however I don't know what to do for this... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review