Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454102 --- Comment #6 from Miroslav Suchy <msuchy@xxxxxxxxxx> 2008-09-10 10:05:38 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=817494 + rpmlint is silent for SRPM and for RPM. FAIL [1] + source files match upstream url 62db4b24d66a56b4f22187452e8ab9a6 Catalyst-Model-XMLRPC-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written FAIL [2] + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful! + Package perl-Filesys-Df-0.92-2.fc10 => Provides: perl(Catalyst::Helper::Model::XMLRPC) perl(Catalyst::Model::XMLRPC) = 0.04 perl-Catalyst-Model-XMLRPC = 0.04-1.fc10 Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst::Model) perl(NEXT) perl(RPC::XML) perl(RPC::XML::Client) perl(base) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 [1] rpmlint -i perl-Catalyst-Model-XMLRPC-0.04-1.fc9.src.rpm perl-Catalyst-Model-XMLRPC.src:39: W: rpm-buildroot-usage %prep FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. [2] perl -pi -e \ 's|\$self->config\(\$config\)|\$self->config\(\$config\) if defined \$config|' \ lib/Catalyst/Model/XMLRPC.pm This is not propper way of patching source. Create patch and include load it using Patch1: pragma. I encourage you to send this patch to upstream as well. Please fix this two issues and then the review can be finished. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review