Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461619 --- Comment #5 from Karsten Hopp <karsten@xxxxxxxxxx> 2008-09-10 08:03:05 EDT --- I leave to OK stuff from the review guidelines away and just list the bad ones: BAD: should use macros when possible, p.e. %{_sysconfdir} for /etc BAD: doesn't build in mock: make -C po update-po ls: cannot access *.po : No such file or directory BAD: rpmlint warning for switch-displaymanager-1.0-1.noarch.rpm: switch-displaymanager.noarch: W: no-dependency-on usermode BAD: rpmlint warning for switch-displaymanager-gnome-1.0-1.noarch.rpm: switch-displaymanager-gnome.noarch: E: description-line-too-long The switch-displaymanager-gnome package provides the GNOME graphical user interface BAD: buildroot isn't the most preferred one: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) BAD: http://than.fedorapeople.org/switch-displaymanager.spec doesn't use desktop-file-install (comment #1) BAD: unversioned requirement in the gnome subpackage on the main package BAD: packages don't have license text included (%doc) BAD: errors when switch-displaymanager-gnome is run the first time: > switch-displaymanager /bin/cp: cannot stat `/etc/sysconfig/desktop': No such file or directory /bin/cat: /etc/sysconfig/desktop.save: No such file or directory Your default graphical display manager has successfully been switched BAD: errors when switch-displaymanager-gnome is not installed and the commandline is used: >switch-displaymanager KDE /usr/sbin/switch-displaymanager: line 16: /usr/share/switch-displaymanager/switchdesk-helper: No such file or directory /usr/sbin/switch-displaymanager: line 16: exec: /usr/share/switch-displaymanager/switchdesk-helper: cannot execute: No such file or directory NOTE: man page from Mon Feb 14 2000 for a newly written program ? NOTE: doesn't use smp flags during build, probably not needed because package contains only scripts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review