Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460297 Neil Horman <nhorman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(limb@xxxxxxxxxxxx | |) --- Comment #1 from Neil Horman <nhorman@xxxxxxxxxx> 2008-09-09 14:25:38 EDT --- 1) rpmlint must be run on every package. The output should be posted in the review. PASS: [nhorman@hmsreliant Desktop]$ rpmlint -v ./apricots-0.2.6-1.fc9.src.rpm apricots.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 2) The package must be named according to the Package Naming Guidelines PASS 3) The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption PASS 4) The package must meet the Packaging Guidelines PASS 5) The package must be licensed with a Fedora approved license and meet the Licensing Guidelines PASS (althought its noted that the sources contain the GPLv2 license, but the website claims distribution under the GPL). Don't think the website language really matters though, given that the source is distributed with v2 and that matches the spec file 6)The License field in the package spec file must match the actual license PASS 7)If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc PASS (COPYING listed as %doc) 8) The spec file must be written in American English PASS 9) The spec file for the package MUST be legible PASS 10) he sources used to build the package must match the upstream source FAIL md5sum ~/rpmbuild/SOURCES/apricots-0.2.6.tar.gz e185753be2a35a5743a5f26c6444aee6 /home/nhorman/rpmbuild/SOURCES/apricots-0.2.6.tar.gz from http://www.fishies.org.uk/apricots-0.2.6.tar.gz md5sum apricots-0.2.6.tar.gz 910828d717e46d8cbd9c24f702d09fbc apricots-0.2.6.tar.gz Can you look into the discrepany there please? I'll continue reviewing as soon as we figure out whats going on here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review