Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461619 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2008-09-09 11:25:36 EDT --- neat. A few initial comments. 0. a koji scratch build would be nice. :) 1. Use desktop-file-install for the .desktop file(s) 2. fix License tag (ie, GPL is not valid per http://fedorproject.org/wiki/Licensing) 3. -gui subpkg (pygtk2?, eww...) anyway, shouldn't it have additional deps, maybe something like: Requires: pygtk2 4. Source url, if there's no current upstream for this, please add a comment in the specfile saying so. Long-term, would be nice to get this hosted somewhere, maybe fedorahosted? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review