Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456341 Victor G. Vasilyev <victor.vasilyev@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|langel@xxxxxxxxxx |nobody@xxxxxxxxxxxxxxxxx Flag|needinfo?(victor.vasilyev@s | |un.com) | --- Comment #12 from Victor G. Vasilyev <victor.vasilyev@xxxxxxx> 2008-09-08 10:10:02 EDT --- The next release is prepared for review. Spec URL: http://nbi.netbeans.org/files/documents/210/2059/netbeans-platform8.spec SRPM URL: http://nbi.netbeans.org/files/documents/210/2173/netbeans-platform8-6.1-4.fc10.src.rpm Changes (In reply to comment #11): > Can the file linking be moved to %build or %install? It is also possibly these > create files that end up being unowned by the package. > > XXXX MUST: rpmlint must be run on every package. The output should be posted in > the review. > See comments above > > XXXX MUST: A package must own all directories that it creates. If it does not > create a directory that it uses, then it should require a package which does > create that directory. Refer to the Guidelines for examples. > see rpmlint comments OK. The linking to the external JARs is moved to the %%install script from the %%post scripts. I agree that such solution will decrease risks of creating files which are unowned by the package, but it will also increase number of the rpmlint warnings (dangling-symlink). Also, regardless of the fact that the rpmlint shows the symlink-should-be-relative warnings I intentionally use absolute links to the external JARs, because I am sure that in this case the links to the external components should not depend on locations of the symlinks in the package directory tree. So, now the rpmlint shows the following warnings against RPMs: * 14 warnings against netbeans-platform8-6.1-4.fc10.noarch.rpm, including: - 4 "dangling-symlink" and 4 "symlink-should-be-relative" for all 4 external JARs - 1 "dangerous-command-in-%preun rm" for the noautoupdate file - 5 "class-path-in-manifest" for 5 NetBeans JARs that use such method * 3 warnings against netbeans-platform8-harness-6.1-4.fc10.noarch.rpm, including: - 1 "dangling-symlink" and 1 "symlink-should-be-relative" for 1 external JAR - 1 "dangerous-command-in-%preun rm" for the noautoupdate file > XXXX MUST: Permissions on files must be set properly. Executables should > be set with executable permissions, for example. Every %files section must > include a %defattr(...) line. > > Fix permissions on line 245: %defattr(-,root,root) to %defattr(-,root,root,-) - Fixed for the package and subpackages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review