[Bug 458939] Review Request: arora - a cross platform web browser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458939





--- Comment #4 from Jonathan Roberts <jonathan.roberts.uk@xxxxxxxxxxxxxx>  2008-09-08 07:47:43 EDT ---
RPM Lint: OK (silent)
Package name: OK
Spec file: OK
License: OK
Actual License: OK
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK
Compile and Build:
 - F-8: FAIL (see note)
 - F-9: FAIL (see note)
 - rawhide: OK
 - EL-5: FAIL (see notes)

Applicable Package Guidelines:

Locales: OK
Shared libs: NA

Relocatable: NA
Directory and file ownership: NOT OK (see mustfix)
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: NA
(Large) Documentation: NA
%doc affecting runtime: NA
Header files in -devel package: NA
Static Libraries in -static package: NA
pkgconfig Requires: NA
Library files: NA
Devel requires base package: NA
.la libtool archives: NA
Duplicate ownership of files/directories: NOT OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Summary:

MUST FIX:

* Package specifies:
 %{_datadir}/icons/*
 %{_datadir}/pixmaps/*   
Takes ownership of directories that don't belong to the package, and it should
in fact own the files that it puts in a subdirectory of the ones listed. 

SHOULD:

* Might be nice to provide a description that doesn't provide developer related
information like length of code base and "it's fun to hack on".

NOTES:

* This package requires qt-devel => 4.4, meaning it will only build in rawhide
currently. Packages are in updates-testing for future inclusion in F9 and F8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]