Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461386 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-09-07 12:58:28 EDT --- These could almost be machine-reviewed.... * source files match upstream: ce22a834bbe79e2ff5c01709becffaf0c9a7d71b3bd94b2e07b611fe4f0375be Class-Method-Modifiers-1.01.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Class::Method::Modifiers) = 1.01 perl-Class-Method-Modifiers = 1.01-1.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(MRO::Compat) perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=25, Tests=115, 1 wallclock secs ( 0.06 usr 0.04 sys + 0.56 cusr 0.11 csys = 0.77 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review