Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457561 --- Comment #1 from Hans Ulrich Niedermann <rhbugs@xxxxxxxxxxxxxxxx> 2008-09-07 10:14:22 EDT --- OK source files match upstream: The URL: links to a different place with the same tarball as Source: 4d4de9e6aa4b2bf6d64645353edc02d8f4f13d0c pthsem_2.0.7.tar.gz (from Source:) 4d4de9e6aa4b2bf6d64645353edc02d8f4f13d0c pthsem_2.0.7.tar.gz (from SRPM) 4d4de9e6aa4b2bf6d64645353edc02d8f4f13d0c pthsem-2.0.7.tar.gz (from URL:) Files match, but the different locations are confusing. FAIL %description talks of "GNU pthsem" which does not appear to exist. OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. FAIL dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. LGPLv2+ (to be exact: LGPL 2.1 or later) OK license text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. http://koji.fedoraproject.org/koji/taskinfo?taskID=811801 OK package installs properly. OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires are sane: pthsem-2.0.7-1.i386.rpm provides libpthsem.so.20 pthsem = 2.0.7-1 pthsem-debuginfo-2.0.7-1.i386.rpm provides libpthsem.so.20.0.27.debug pthsem-debuginfo = 2.0.7-1 pthsem-devel-2.0.7-1.i386.rpm provides pthsem-devel = 2.0.7-1 pthsem-2.0.7-1.i386.rpm requires /sbin/ldconfig /sbin/ldconfig libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libpthsem.so.20 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) pthsem-debuginfo-2.0.7-1.i386.rpm requires libpthsem.so.20 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 pthsem-devel-2.0.7-1.i386.rpm requires /bin/sh libpthsem.so.20 pthsem = 2.0.7-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 OK %check is present and all tests pass: rpmbuild does not abort OK shared libraries are present, ldconfig is run OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers. OK no pkgconfig files. OK libtool .la droppings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review