Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461400 Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(pavel.lisy@gmail. | |com) --- Comment #1 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2008-09-07 07:32:45 EDT --- RPM Lint: The following warnings occur during rpmlint -i: * cherokee.i386: W: non-standard-uid /var/lib/cherokee cherokee * cherokee.i386: W: non-standard-gid /var/lib/cherokee cherokee These are OK, rpmlint just isn't *that* smart * cherokee.i386: W: symlink-should-be-relative /usr/sbin/rccherokee /etc/init.d/cherokee Although the symlink should be relative, instead I'd nuke the rccherokee from /usr/sbin/ altogether, if that is possible. Suggestion: remove line 57, which says: %{__ln_s} -f %{_sysconfdir}/init.d/%{name} %{buildroot}%{_sbindir}/rc%{name} * cherokee.i386: W: non-conffile-in-etc /etc/pam.d/cherokee Suggestion: make this file say %config(noreplace) in the %files section. * cherokee.i386: W: non-standard-gid /etc/cherokee cherokee * cherokee.i386: W: non-standard-gid /etc/cherokee/ssl cherokee * cherokee.i386: E: non-standard-dir-perm /etc/cherokee 0750 * cherokee.i386: E: non-standard-dir-perm /etc/cherokee/ssl 0750 Suggestion: replace the following lines in the %files section: %dir %attr(750,root,%{name}) %{_sysconfdir}/%{name} %dir %attr(750,root,%{name}) %{_sysconfdir}/%{name}/ssl for: %dir %{_sysconfdir}/%{name} %dir %{_sysconfdir}/%{name}/ssl as their maybe should be no certificates in /etc/cherokee/ssl to begin with, as certificates are usually intended to be in /etc/pki/%{name} * cherokee.i386: W: log-files-without-logrotate /var/log/cherokee Suggestion: Provide a logrotate script for cherokee logfiles. * cherokee.i386: W: incoherent-version-in-changelog 0.8.1 0.8.1-1.fc8 Suggestion: Make the changelog at the very least use: 0.8.1-1 (nevermind the dist-tag) * cherokee.i386: W: invalid-license GPL Suggestion: Change License: tag to GPLv2 * cherokee.i386: W: one-line-command-in-%postun /sbin/ldconfig %postun should also have chkconfig --del %{name} * cherokee.i386: W: service-default-enabled /etc/init.d/cherokee Suggestion: In the init script, make set the default runlevels, but do not enable the service by default. Package name: OK Spec file: OK, but please see the notes below this review item list License: Invalid license tag GPL, from COPYING, use GPLv2 Actual License: GPLv2 (from COPYING file) %doc License: doc files INSTALL, README, COPYING, etc, not installed. Suggest adding to the %files section: %doc README COPYING INSTALL AUTHORS ChangeLog NEWS TODO Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: md5sum matches Compile and Build: - F-8: builds - F-9: builds - rawhide: builds - EL-5: builds Applicable Package Guidelines: Locales: OK Shared libs: N/A (see rpmlint comments) Relocatable: N/A Directory and file ownership: See rpmlint comments No duplicate files in %files: OK File Permissions: See rpmlint comments Macro usage: OK Code vs. Content: OK (Large) Documentation: OK %doc affecting runtime: OK Header files in -devel package: Static Libraries in -static package: N/A pkgconfig Requires: Library files: OK Devel requires base package: OK .la libtool archives: .la files found in /usr/lib/cherokee/. Suggest (after make install): find %{buildroot}/%{_libdir}/%{name} -name *.la -exec rm -rf {} \; Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK * Please do not use /var/www/htdocs, but place files in (for example) /var/www/cherokee maybe, since there's a few webservers out there now that cannot all own variations of /var/www/html, /var/www/htdocs, /var/www/public_html, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review