Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459983 --- Comment #2 from Debarshi Ray <debarshi.ray@xxxxxxxxx> 2008-09-06 13:19:29 EDT --- MUST Items: OK - rpmlint is clean OK - follows Naming Guidelines OK - spec file is named as %{name}.spec xx - package does not meet Packaging Guidelines + Although this is not explicitly mentioned in the guidelines, you need to do 'rm -f $RPM_BUILD_ROOT%{_infodir}/dir' after running 'make install ...' in the %install stanza to avoid overwriting it while installing the package. + To preserve timestamps you could consider using: make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT + The upstream tarball contains an online manual page: doc/moe.1. You might consider shipping it. If you do so, then please use 'install -p' to install it so that the timestamps are preserved. + It is a good idea not to explicitly specify the extension added by the compression scheme to the info and manual pages. Using a wildcard will let the package build if no compression is used or the extension is changed. OK - Fedora approved license and meets Licensing Guidelines OK - License field meets actual license OK - upstream license file included in %doc OK - spec file uses American English OK - spec file is legible OK - sources match upstream sources xx - package fails to build successfully + Incorrect build dependencies and unpackaged %{_infodir}/dir file, which should be removed. OK - ExcludeArch not needed xx - build dependencies incorrectly listed + Missing 'BuildRequires: ncurses-devel'. OK - no locales OK - no shared libraries OK - package is not relocatable OK - file and directory ownership OK - no duplicates in %file OK - file permissions set properly OK - %clean present OK - macros used consistently OK - contains code and permissable content OK - -doc is not needed OK - contents of %doc does not affect the runtime OK - no header files OK - no static libraries OK - no pkgconfig files OK - no library files OK - -devel is not needed OK - no libtool archives OK - %{name}.desktop file not needed OK - does not own files or directories owned by other packages OK - buildroot correctly prepped OK - all file names valid UTF-8 SHOULD Items: OK - upstream provides license text xx - no translations for description and summary xx - package fails to build in mock successfully + Incorrect build dependencies and unpackaged %{_infodir}/dir file, which should be removed. OK - package builds on all supported architectures OK - package functions as expected OK - scriptlets are sane OK - subpackages are not needed OK - no pkgconfig files OK - no file dependencies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review