Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454029 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #8 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-09-05 20:36:18 EDT --- Just noticed this further back in the ticket list. Looks clean enough, builds fine, and elicits no grumbling from rpmlint. The summary is a little lame, but that comes from upstream and I can't suggest anything better. 0.22 was released late August; I don't see any significant differences so I'll go ahead and review 0.21 but I'll take a look at an updated package if you want. * source files match upstream: 0850dbd768eccac5f87e94942604cc239f017a438d9971761f18ad7b9dd2ec3b Catalyst-Model-DBIC-Schema-0.20.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. o summary is OK (not great, but OK). * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Catalyst::Helper::Model::DBIC::Schema) = 0.20 perl(Catalyst::Model::DBIC::Schema) = 0.20 perl-Catalyst-Model-DBIC-Schema = 0.20-2.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst::Runtime) >= 5.70 perl(Class::Accessor::Fast) >= 0.22 perl(Class::Data::Accessor) >= 0.02 perl(DBIx::Class) perl(DBIx::Class::Schema::Loader) >= 0.03012 perl(Data::Dumper) perl(NEXT) perl(UNIVERSAL::require) perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=5, Tests=10, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.84 cusr 0.11 csys = 0.98 CPU) (Test::Kwalitee doesn't seem to be in the distro so those tests are skipped.) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review