Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=461303 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-09-05 20:01:27 EDT --- Fails to build for me (in rawhide); the tests fail due to a lack of Test::More. Even by-the-book cpanspec-generated packages may be missing a few things. I added a build dependency on perl(Test::More) and things build OK, so I'll just assume that it's there and go on. Otherwise everything looks fine. * source files match upstream: 57e73cc7ef596d9b65288223daa252fe1e2cb9a07b79f7e8786c86c6b7e4bbb9 Data-Section-0.005.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (after adding perl(Test::More)). * %clean is present. * package builds in mock (rawhide, x86_64) (after fixing build deps). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Data::Section) = 0.005 perl-Data-Section = 0.005-1.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(Class::ISA) perl(Sub::Exporter) >= 0.979 perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=3, Tests=19, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.07 cusr 0.01 csys = 0.11 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, just fix that build dep so that you can actually build the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review