[Bug 460912] Review Request: DeviceKit-power - Power Management Service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460912





--- Comment #5 from Matthias Clasen <mclasen@xxxxxxxxxx>  2008-09-05 13:28:33 EDT ---


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: says MIT, but COPYING is GPL. What gives ?
license: file: I notice the first line:

   Copyright (C) 2008 David Zeuthen <david@xxxxxxxx> 

   Maybe you want to add yourself there ?

spec language: ok
spec legibility: ok
upstream sources: ok
buildable: ok
excludearch: n/a
build deps: ok
locale handling: n/a
shared libs: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok 
file permissions: ok
%clean: ok
macro use: consistent
content: permissable
large docs: n/a
header files: n/a
static libs: n/a
pc files: n/a
versioned shared libs: n/a
devel->base dep: ok
libtool archives: ok
gui apps: n/a
directory ownership: must not own
  /usr/share/PolicyKit/policy (owned by PolicyKit)
  /usr/share/dbus-1/interfaces (owned by dbus)
%install: ok
utf8 filenames: ok


In summary: 
 - fix the license situation
 - fix directory ownership

then its good to go

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]