Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458548 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #13 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-09-05 12:16:15 EDT --- For 0.7.1-4: * Group - Usually "Group" tag for the main package of this type is "System Environment/Libraries" (and -devel subpackage has "Development/Libraries") ! %setup - "-n %{name}-%{version}" is redundant as the default of %setup directory is this. * autotools call -------------------------------------------- 419 + cd doc ...... 443 config.status: creating Makefile 444 + make -j8 445 cd . && /bin/sh /builddir/build/BUILD/uriparser-0.7.1/missing --run aclocal-1.10 446 /builddir/build/BUILD/uriparser-0.7.1/missing: line 54: aclocal-1.10: command not found 447 WARNING: `aclocal-1.10' is missing on your system. You should only need it if 448 you modified `acinclude.m4' or `configure.in'. You might want 449 to install the `Automake' and `Perl' packages. Grab them from 450 any GNU archive site. 451 cd . && /bin/sh /builddir/build/BUILD/uriparser-0.7.1/missing --run autoconf ...... -------------------------------------------- - Automated autotool calls after configure is not desired. Usually timestamps on some files (aclocal.m4 and so on) are wrong. You can avoid this by "touch"ing some files. * Timestamp - Please consider to use -------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" -------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for recent autotool based Makefiles. * Documents install -------------------------------------------- # doc folder make install does nothing install -d $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/html/ install -p -m 0644 doc/html/* $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/html/ -------------------------------------------- - Well, this does not do anything (and can be removed completely) ... Actually in -devel package the directory %{_docdir}/%{name}-%{version}/html/ does not exist. This is because of %doc invocation. As build.log shows what %doc actually does (when the list in %doc does not begin with /) is: -------------------------------------------- 663 Processing files: uriparser-0.7.1-4.fc10 664 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.hz0MmE 665 + umask 022 666 + cd /builddir/build/BUILD 667 + cd uriparser-0.7.1 668 + DOCDIR=/builddir/build/BUILDROOT/uriparser-0.7.1-4.fc10.i386/usr/share/doc/uriparser-0.7.1 669 + export DOCDIR 670 + rm -rf /builddir/build/BUILDROOT/uriparser-0.7.1-4.fc10.i386/usr/share/doc/uriparser-0.7.1 671 + /bin/mkdir -p /builddir/build/BUILDROOT/uriparser-0.7.1-4.fc10.i386/usr/share/doc/uriparser-0.7.1 672 + cp -pr THANKS AUTHORS COPYING /builddir/build/BUILDROOT/uriparser-0.7.1-4.fc10.i386/usr/share/doc/uripars er-0.7.1 673 + exit 0 -------------------------------------------- See the line 670. %doc once removes all files under $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/. * Documents - Please consider to add the following file to %doc. -------------------------------------------- ChangeLog -------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review